fix(ci): add ready_for_review type to pull request triggers for pre-commit workflow
#1241
Conversation
|
I'm slightly confused as to why these workflows aren't triggered. At least the codeql one has ready_for_review as trigger but the others don't. Wouldn't it be easier to just add that trigger there too? |
|
I assume for the same reason as github/codeql-action#2858? Unless that's specific to dependabot. |
|
That's the point of having these release PRs marked as draft first. Then someone goes in and moves them to "ready for review" and the jobs should be triggered 🙂 |
|
I'm pretty sure it was still waiting on CodeQL to pass even after the actions ran via |
|
Hey, I think Horst has a point here, if adding the ready_for_review trigger to all actions would work then I think that's a better approach. Currently, only the pre-commit workflow is not running when we "undraft" the PR. CodeQL and other workflows would run. |
|
Will update the PR to try the |
juliajohannesen
force-pushed
the
juliajohannesen/fix-codeql-bug
branch
from
eaf0868 to
5833b5c
Compare
juliajohannesen
changed the title
ready_for_review type to pull request triggers for pre-commit workflow
Currently,
release-pleasePRs (and other PRs triggered by bots) are getting blocked by certain checks that aren't getting triggered, namelypre-commit, which lacks aready_for_reviewpull request trigger type, meaning it never gets ran on bot PRs, as the other trigger types don't get activated. This PR should resolve that.Old description
#1036 is currently stuck on some CI jobs as a result of CodeQL, pre-commit, and Zizmor not working when the PR author is
github-actions[bot]. This PR allows them to be skipped in that case, but addspolicy-botto enforce that.One question is if any work needs to be done to apply the same restrictions laid out in this part of our terraform config for this repository.